[PATCH 2/2] nvme-rdma: move admin queue cleanup to nvme_rdma_free_ctrl

J Freyensee james_p_freyensee at linux.intel.com
Wed Jul 13 16:19:46 PDT 2016


>  static void nvme_rdma_free_ctrl(struct nvme_ctrl *nctrl)
> @@ -687,6 +684,10 @@ static void nvme_rdma_free_ctrl(struct nvme_ctrl
> *nctrl)
>  	list_del(&ctrl->list);
>  	mutex_unlock(&nvme_rdma_ctrl_mutex);
>  
> +	blk_cleanup_queue(ctrl->ctrl.admin_q);
> +	blk_mq_free_tag_set(&ctrl->admin_tag_set);
> +	nvme_rdma_dev_put(ctrl->device);
> +
>  	if (ctrl->ctrl.tagset) {
>  		blk_cleanup_queue(ctrl->ctrl.connect_q);
>  		blk_mq_free_tag_set(&ctrl->tag_set);

This patch does not remove the second

nvme_rdma_dev_put(ctrl->device);

call that happens within the if() statement above if it evaluates to
TRUE.  Should that have been removed or moved elsewhere?





More information about the Linux-nvme mailing list