[PATCH 2/5] nvme: introduce a controller state machine

Sagi Grimberg sagi at grimberg.me
Mon Apr 18 13:30:34 PDT 2016


>>> -	clear_bit(NVME_CTRL_RESETTING, &dev->flags);
>>> +	if (!nvme_change_ctrl_state(&dev->ctrl, NVME_CTRL_LIVE)) {
>>> +		dev_warn(dev->ctrl.device, "failed to mark controller live\n");
>>> +		goto out;
>>> +	}
>>>    	return;
>>>
>>>     out:
>>
>> You're missing a state change before removing a
>> dead controller...
>
> why?

Just to have the state consistent with what the driver
is doing. Not a must though...



More information about the Linux-nvme mailing list