[PATCH] NVME: Splitting large i/o in the ioctl path

Jens Axboe axboe at kernel.dk
Fri Feb 20 10:34:31 PST 2015


On 02/20/2015 10:31 AM, Keith Busch wrote:
> On Fri, 20 Feb 2015, Sathayavathi M wrote:
>> +    else
>> +        dev->max_hw_sectors = BLK_DEF_MAX_SECOTRS;
>
> I think you meant BLK_DEF_MAX_SECTORS. Sometimes I submit patches that
> don't compile either. :)

Coincidentally, that define has been removed recently...

> Anyway, I think we need to fix the driver's adding disks of this extended
> type first. Right now I think we're corrupting data and memory if we
> encounter such a device. I proposed setting the capacity to 0 so you
> can still access the disk media through the ioctl, but not through the
> standard block layer.

Agree.

-- 
Jens Axboe




More information about the Linux-nvme mailing list