[patch] nvme: precedence bug in nvme_pr_clear()
Keith Busch
keith.busch at intel.com
Wed Dec 9 10:00:22 PST 2015
On Wed, Dec 09, 2015 at 10:56:37AM -0700, Jens Axboe wrote:
> On 12/09/2015 03:24 AM, Dan Carpenter wrote:
> >The "|" operator has higher precedence than "?:" so this didn't work as
> >intended. I had previously fixed this bug, but it we copied the older
> >unfixed version when we moved the function between files.
> >
> >Fixes: 1673f1f08c88 ('nvme: move block_device_operations and ns/ctrl freeing to common code')
> >Signed-off-by: Dan Carpenter <dan.carpenter at oracle.com>
>
> Dejavu, but I guess in a different function. Christoph, you are
> hereby banned from ever using ?:!
Ah, that came from me. I wrote the patch on one machine, tested on
another. The tests required those issues be fixed, but the fixes didn't
propgate back to the original machine that generated the patch.
git user fail...
More information about the Linux-nvme
mailing list