[PATCH] NVMe: Expose namespace unique identifier to sysfs

Dan Williams dan.j.williams at intel.com
Wed Dec 9 00:12:30 PST 2015


On Tue, Dec 8, 2015 at 11:15 AM, Keith Busch <keith.busch at intel.com> wrote:
> On Tue, Dec 08, 2015 at 01:53:25PM -0500, Matthew Wilcox wrote:
>> On Tue, Dec 08, 2015 at 10:26:45AM -0700, Keith Busch wrote:
>> > This patch determines which the device supports and reports the unique
>> > identifier in new sysfs binary attribute "uuid". The attribute group is
>> > added to the gendisk's kobject directory.
>>
>> I don't understand why we want to produce a binary attribute here instead
>> of a text attribute?  We already have nicely-formatted UUIDs in sysfs
>> (see the %pU specifier to printk)
>
> I don't have a strong opinion here. Just copying scsi vpd83 attribute,
> and thought it's easier for a program to consume as binary, and easy to
> read from the shell with hexdump.

Fwiw, the nvdimm subsystem dumps namespace uuids as text in sysfs, and
libuuid makes it trivial to convert back and forth.



More information about the Linux-nvme mailing list