[PATCH 1/2] nvme: remove spurious use of *_to_cpup helpers

[Jens Axboe]

On 08/17/2015 02:12 PM, Matthew Wilcox wrote:
> On Mon, Aug 17, 2015 at 09:09:39PM +0200, Christoph Hellwig wrote:
>> Switch to the normal endianess helpers that take an integer instead of
>> the pointer to it.
>
> Why?  Some CPUs have a 'load-reversed-endian' instruction, which can be
> used in the _to_cpup() cases, but not in the _to_cpu() cases.
>
>> -				cqe->command_id, le16_to_cpup(&cqe->sq_id));
>> +				cqe->command_id, le16_to_cpu(cqe->sq_id));

All those nvme equipped sparc and s390's? :-)

Joke aside, do we really have that 'load-reversed-endian' addition to 
the endianness conversion API just because of two rather esoteric 
platforms? Seems silly.

-- 
Jens Axboe