[PATCH 1/2] nvme: remove spurious use of *_to_cpup helpers

Matthew Wilcox willy at linux.intel.com
Mon Aug 17 13:12:37 PDT 2015


On Mon, Aug 17, 2015 at 09:09:39PM +0200, Christoph Hellwig wrote:
> Switch to the normal endianess helpers that take an integer instead of
> the pointer to it.

Why?  Some CPUs have a 'load-reversed-endian' instruction, which can be
used in the _to_cpup() cases, but not in the _to_cpu() cases.

> -				cqe->command_id, le16_to_cpup(&cqe->sq_id));
> +				cqe->command_id, le16_to_cpu(cqe->sq_id));



More information about the Linux-nvme mailing list