[PATCH v2] nvme: consolidate synchronous command submission helpers

Keith Busch keith.busch at intel.com
Fri Apr 17 15:17:45 PDT 2015


On Fri, 17 Apr 2015, Christoph Hellwig wrote:
> -static int nvme_submit_sync_cmd(struct request *req, struct nvme_command *cmd,
> -						u32 *result, unsigned timeout)
> +int nvme_submit_sync_cmd(struct request_queue *q, struct nvme_command *cmd,
> +		u32 *result)

A late catch not even caused by your patch, but can we keep the timeout
param? We should honor the requested timeout for passthrough commands,
and it was already broken before, but will be a one-line fix if we don't
remove it here.



More information about the Linux-nvme mailing list