[PATCH] NVMe: Change nvme_enable_ctrl behavior and track CC

[Dan McLeran]

Hmm. You're right. I guess I thought setting EN to 0 would have cleared 
out the shutdown bits. I guess not.

On Fri, 20 Jun 2014, Keith Busch wrote:

> On Fri, 20 Jun 2014, Dan McLeran wrote:
>> nvme_probe as it is written today essentially clears out any the shutdown 
>> bits during enable. If you unload/reload the nvme module you'll see that 
>> the normal shutdown bits are set before the controller gets enabled. The 
>> nvme_remove path calls nvme_shutdown_ctrl but not nvme_disable_ctrl. Maybe 
>> the nvme_probe path should always disable the controller first before 
>> enabling to ensure we're starting clean?
>
> But we already do that. We probably want nvme_disable_ctrl to also clear
> the CC.SHN bits in addition to CC.EN, though.
>