[PATCH 0/4] nvme-blkmq fixes
Keith Busch
keith.busch at intel.com
Tue Dec 23 13:23:41 PST 2014
On Tue, 23 Dec 2014, Keith Busch wrote:
> @@ -432,7 +432,8 @@ static void req_completion(struct nvme_queue *nvmeq, void
> *ctx,
> if (!(status & NVME_SC_DNR || blk_noretry_request(req))
> && (jiffies - req->start_time) < req->timeout) {
> blk_mq_requeue_request(req);
> - blk_mq_kick_requeue_list(req->q);
> + if (!blk_queue_stopped(req->q))
> + blk_mq_kick_requeue_list(req->q);
> return;
> }
Oops, experimenting with different things, took the wrong snapshot of
the patch. Should be:
+ if (nvmeq->cq_vector != -1)
rather than:
+ if (!blk_queue_stopped(req->q))
Anyway, I'm going to keep messing with this until I can either hit the
other failures I mentioned or convince myself it's safe before sending
something for official consideration.
More information about the Linux-nvme
mailing list