[PATCH 4/7] mtd: rawnand: qcom: Simplify with scoped for each OF child loop

Manivannan Sadhasivam mani at kernel.org
Sun Jan 4 23:45:45 PST 2026


On Fri, Jan 02, 2026 at 01:49:31PM +0100, Krzysztof Kozlowski wrote:
> Use scoped for-each loop when iterating over device nodes to make code a
> bit simpler.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski at oss.qualcomm.com>

Reviewed-by: Manivannan Sadhasivam <mani at kernel.org>

- Mani

> ---
>  drivers/mtd/nand/raw/qcom_nandc.c | 8 +++-----
>  1 file changed, 3 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
> index 4dd6f1a4e797..b7e79b76654d 100644
> --- a/drivers/mtd/nand/raw/qcom_nandc.c
> +++ b/drivers/mtd/nand/raw/qcom_nandc.c
> @@ -2206,16 +2206,14 @@ static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc,
>  static int qcom_probe_nand_devices(struct qcom_nand_controller *nandc)
>  {
>  	struct device *dev = nandc->dev;
> -	struct device_node *dn = dev->of_node, *child;
> +	struct device_node *dn = dev->of_node;
>  	struct qcom_nand_host *host;
>  	int ret = -ENODEV;
>  
> -	for_each_available_child_of_node(dn, child) {
> +	for_each_available_child_of_node_scoped(dn, child) {
>  		host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL);
> -		if (!host) {
> -			of_node_put(child);
> +		if (!host)
>  			return -ENOMEM;
> -		}
>  
>  		ret = qcom_nand_host_init_and_register(nandc, host, child);
>  		if (ret) {
> -- 
> 2.51.0
> 

-- 
மணிவண்ணன் சதாசிவம்



More information about the linux-mtd mailing list