[PATCH mtd-utils v2] tests: add test_DATA to EXTRA_DIST

Zhihao Cheng chengzhihao1 at huawei.com
Thu Feb 20 00:48:39 PST 2025


在 2025/2/20 16:38, Michael Olbrich 写道:
> Otherwise, the test files are missin in the tarball and building fails
> with:
> 
> make[1]: *** No rule to make target 'tests/ubifs_tools-tests/images/good.gz', needed by 'all-am'.  Stop.
> 
> unless --without-tests is uses.
> 
> Signed-off-by: Michael Olbrich <m.olbrich at pengutronix.de>
> ---
> 
> Changes in v2:
>   - introduce a new variable for the test files
>   - extend EXTRA_DIST in tests/ubifs_tools-tests/Makemodule.am instead of
>     the toplevel Makefile.am
> 
> I've used a different name for the new variable to make is less generic.
> 
>   tests/ubifs_tools-tests/Makemodule.am | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/ubifs_tools-tests/Makemodule.am b/tests/ubifs_tools-tests/Makemodule.am
> index 1715757e3188..4ce3f3393448 100644
> --- a/tests/ubifs_tools-tests/Makemodule.am
> +++ b/tests/ubifs_tools-tests/Makemodule.am
> @@ -10,7 +10,7 @@ test_SCRIPTS += \
>   	tests/ubifs_tools-tests/fsck_tests/fsck_bad_image.sh \
>   	tests/ubifs_tools-tests/mkfs_tests/build_fs_from_dir.sh
>   
> -test_DATA += \
> +TEST_IMAGE_FILES = \
>   	tests/ubifs_tools-tests/images/good.gz \
>   	tests/ubifs_tools-tests/images/sb_fanout.gz \
>   	tests/ubifs_tools-tests/images/sb_fmt_version.gz \
> @@ -64,3 +64,6 @@ test_DATA += \
>   	tests/ubifs_tools-tests/images/dir_lost_not_recover.gz \
>   	tests/ubifs_tools-tests/images/root_dir.gz \
>   	tests/ubifs_tools-tests/images/empty_tnc.gz
> +
> +test_DATA += $(TEST_IMAGE_FILES)
> +EXTRA_DIST +=$(TEST_IMAGE_FILES)

EXTRA_DIST += $(TEST_IMAGE_FILES)
A whitespace is needed here.
> 


Reviewed-by: Zhihao Cheng <chengzhihao1 at huawei.com>



More information about the linux-mtd mailing list