[PATCH mtd-utils] tests: add test_DATA to EXTRA_DIST

Zhihao Cheng chengzhihao1 at huawei.com
Wed Feb 19 04:00:30 PST 2025


在 2025/2/19 16:27, Michael Olbrich 写道:
> Otherwise, the test files are missin in the tarball and building fails
> with:
> 
> make[1]: *** No rule to make target 'tests/ubifs_tools-tests/images/good.gz', needed by 'all-am'.  Stop.
> 
> unless --without-tests is uses.
> 
> Signed-off-by: Michael Olbrich <m.olbrich at pengutronix.de>
> ---
>   Makefile.am | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index c7561272fab3..9efcacc6991a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -70,3 +70,5 @@ endif
>   if UNIT_TESTS
>   include tests/unittests/Makemodule.am
>   endif
> +
> +EXTRA_DIST += $(test_DATA)
> 

Hi, Michael. How abour changing like this?
diff --git a/tests/ubifs_tools-tests/Makemodule.am 
b/tests/ubifs_tools-tests/Makemodule.am
index 1715757..db77bad 100644
--- a/tests/ubifs_tools-tests/Makemodule.am
+++ b/tests/ubifs_tools-tests/Makemodule.am
@@ -10,8 +10,7 @@ test_SCRIPTS += \
         tests/ubifs_tools-tests/fsck_tests/fsck_bad_image.sh \
         tests/ubifs_tools-tests/mkfs_tests/build_fs_from_dir.sh

-test_DATA += \
-       tests/ubifs_tools-tests/images/good.gz \
+IMAGE_FILES = tests/ubifs_tools-tests/images/good.gz \
         tests/ubifs_tools-tests/images/sb_fanout.gz \
         tests/ubifs_tools-tests/images/sb_fmt_version.gz \
         tests/ubifs_tools-tests/images/sb_leb_size.gz \
@@ -64,3 +63,6 @@ test_DATA += \
         tests/ubifs_tools-tests/images/dir_lost_not_recover.gz \
         tests/ubifs_tools-tests/images/root_dir.gz \
         tests/ubifs_tools-tests/images/empty_tnc.gz
+
+test_DATA += $(IMAGE_FILES)
+EXTRA_DIST += $(IMAGE_FILES)



More information about the linux-mtd mailing list