[PATCH v3 1/2] mtd: spi-nand: Add read retry support

[Miquel Raynal]

Hello,

>> > +                             ret = spinand->set_read_retry(spinand, retry_mode);
>> > +                             if (ret < 0) {
>> > +                                     ecc_failed = true;
>> > +                                     return ret;
>>
>> Shall we try to set the read_retry level to 0 upon:
>>
>>       if (ret < 0 && retry_mode > 1)
>>
>> ?
>
> If we set the read_retry level to 0 upon, and set_read_retry fails
> when retry_mode equals to 1, it won't return an error. This could
> potentially mask an underlying issue.

Don't save the return value in this case? But otherwise you would leave
the chip in a retry state, no?

Thanks,
Miquèl