[PATCH 06/41] mtd: spi-nor: default page_size to 256 bytes
Miquel Raynal
miquel.raynal at bootlin.com
Mon Aug 7 07:33:40 PDT 2023
Hi Michael,
michael at walle.cc wrote on Mon, 07 Aug 2023 16:29:38 +0200:
> Hi Miquel,
>
> >> + params->page_size = info->page_size ?: SPI_NOR_DEFAULT_PAGE_SIZE;
> >
> > Would you mind clarifying this? It does not look right, while
> > perhaps it is. But TBH, I have no idea what params->page_size will be
> > after this assignment.
>
> It's info->page_size, it's a shortcut [1].
Elvis operator :')
> I'm not the first one using it (in fact I was explicitly asked to use it,
> e.g. in gpio subsys):
>
> $ grep -r "?:" **/*.c |wc -l
> 1268
Okay then... I didn't know this was encouraged.
> -michael
>
> [1] https://en.wikipedia.org/wiki/Elvis_operator
Thanks,
Miquèl
More information about the linux-mtd
mailing list