[bug report] mtd: parsers: Add Qcom SMEM parser

[Dan Carpenter]

On Fri, Jan 08, 2021 at 06:58:28PM +0530, Manivannan Sadhasivam wrote:
> Hi Dan,
> 
> On Fri, Jan 08, 2021 at 03:52:41PM +0300, Dan Carpenter wrote:
> > Hello Manivannan Sadhasivam,
> > 
> > The patch 803eb124e1a6: "mtd: parsers: Add Qcom SMEM parser" from Jan
> > 4, 2021, leads to the following static checker warning:
> > 
> > 	drivers/mtd/parsers/qcomsmempart.c:109 parse_qcomsmem_part()
> > 	warn: passing zero to 'PTR_ERR'
> > 
> > drivers/mtd/parsers/qcomsmempart.c
> >     68          pr_debug("Parsing partition table info from SMEM\n");
> >     69          ptable = qcom_smem_get(SMEM_APPS, SMEM_AARM_PARTITION_TABLE, &len);
> >     70          if (IS_ERR(ptable)) {
> > 
> > Can "ptable" be NULL here?
> > 
> 
> No it won't. It will return valid error ptr in failure cases.

The Smatch warning is actually about the IS_ERR_OR_NULL() later.  If it
returns NULL then that's counted as success.  It's sometimes intentional
but here is seems like qcom_smem_get() never returns NULL so it could
be changed to just IS_ERR().

regards,
dan carpenter