[PATCH 2/5] mtd: spinand: Move ECC related definitions earlier in the driver

Miquel Raynal miquel.raynal at bootlin.com
Thu Oct 1 04:36:24 EDT 2020


Hi Thomas,

Thomas Petazzoni <thomas.petazzoni at bootlin.com> wrote on Wed, 30 Sep
2020 20:52:26 +0200:

> On Wed, 30 Sep 2020 17:41:06 +0200
> Miquel Raynal <miquel.raynal at bootlin.com> wrote:
> 
> > Prepare the creation of a SPI-NAND on-die ECC engine by gathering the
> > ECC-related code earlier enough in the core to avoid the need for
> > forward declarations.
> > 
> > The next step is to actually create that engine by implementing the
> > generic ECC interface.
> > 
> > Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> > ---
> >  drivers/mtd/nand/spi/core.c              | 106 +++++++++++------------
> >  drivers/mtd/nand/spi/on-die-ecc-engine.c |   0
> >  2 files changed, 53 insertions(+), 53 deletions(-)
> >  create mode 100644 drivers/mtd/nand/spi/on-die-ecc-engine.c  
> 
> You're adding an empty on-die-ecc-engine.c file in this commit.
> 
> Thomas

Mmmh, this is a left over from a previous implementation, I didn't see
it in the diff, thanks for spotting it!

Cheers,
Miquèl



More information about the linux-mtd mailing list