[PATCH 17/19] mtd: rawnand: r852: Move the ECC initialization to ->attach_chip()

Miquel Raynal miquel.raynal at bootlin.com
Thu Nov 19 15:46:51 EST 2020


On Fri, 2020-11-13 at 12:34:22 UTC, Miquel Raynal wrote:
> The probe function is only supposed to initialize the controller
> hardware but not the ECC engine. Indeed, we don't know anything about
> the NAND chip(s) at this stage. Let's move the logic initializing the
> ECC engine, even pretty simple, to the ->attach_chip() hook which gets
> called during nand_scan() routine, after the NAND chip discovery. As
> the previously mentioned logic is supposed to parse the DT for us, it
> is likely that the chip->ecc.* entries be overwritten. So let's avoid
> this by moving these lines to ->attach_chip().
> 
> Fixes: d7157ff49a5b ("mtd: rawnand: Use the ECC framework user input parsing bits")
> Signed-off-by: Miquel Raynal <miquel.raynal at bootlin.com>
> Cc: Maxim Levitsky <maximlevitsky at gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes.

Miquel



More information about the linux-mtd mailing list