[PATCH 06/14] block: lift setting the readahead size into the block layer

Johannes Thumshirn Johannes.Thumshirn at wdc.com
Wed Jul 22 03:13:54 EDT 2020

On 22/07/2020 08:27, Christoph Hellwig wrote:
> +	q->backing_dev_info->ra_pages =
> +		max(queue_io_opt(q) * 2 / PAGE_SIZE, VM_READAHEAD_PAGES);

Dumb question, wouldn't a '>> PAGE_SHIFT' be better instead of a potentially 
costly division?

Or aren't we caring at all as it's a) not in the fast-path and b) compilers 
can optimize it to a shift?

More information about the linux-mtd mailing list