[PATCH v4 5/6] mtd: rawnand: atmel: Convert the driver to exec_op()

Boris Brezillon boris.brezillon at collabora.com
Mon Jul 20 07:52:54 EDT 2020


On Mon, 20 Jul 2020 07:27:58 +0300
Tudor Ambarus <tudor.ambarus at microchip.com> wrote:

> +static int atmel_smc_nand_exec_op(struct atmel_nand *nand,
> +				  const struct nand_operation *op,
> +				  bool check_only)
> +{
> +	struct atmel_nand_controller *nc;
> +	unsigned int i;
> +	int ret = 0;
> +
> +	if (check_only)
> +		return 0;
> +
> +	nc = to_nand_controller(nand->base.controller);

0day bots complained about this unused var when I submitted v3.

> +	atmel_nand_select_target(nand, op->cs);
> +	gpiod_set_value(nand->activecs->csgpio, 0);
> +	for (i = 0; i < op->ninstrs; i++) {
> +		ret = atmel_smc_nand_exec_instr(nand, &op->instrs[i]);
> +		if (ret)
> +			break;
> +	}
> +	gpiod_set_value(nand->activecs->csgpio, 1);
> +
> +	return ret;
> +}



More information about the linux-mtd mailing list