[PATCH v3 10/14] mtd: rawnand: prepare the removal of the ONFI parameter page

[Boris Brezillon]

On Fri,  2 Mar 2018 15:24:18 +0100
Miquel Raynal <miquel.raynal at bootlin.com> wrote:

> diff --git a/include/linux/mtd/rawnand.h b/include/linux/mtd/rawnand.h
> index 1af0bff58ff4..81236b3fbc6f 100644
> --- a/include/linux/mtd/rawnand.h
> +++ b/include/linux/mtd/rawnand.h
> @@ -429,9 +429,23 @@ struct nand_jedec_params {
>  	__le16 crc;
>  } __packed;
>  
> +struct onfi_params {
> +	u16 t_prog;
> +	u16 t_bers;
> +	u16 t_r;
> +	u16 t_ccs;
> +	u16 async_timing_mode;
> +	u16 vendor_revision;
> +	u8 vendor[88];
> +};

Kernel-doc missing here.

> +
>  struct nand_parameters {
> +	/* Generic parameters */
>  	char model[100];
>  	bool supports_set_get_features;
> +
> +	/* ONFI parameters */
> +	struct onfi_params onfi_params;

Why not name the field onfi instead of onfi_params?

>  };


-- 
Boris Brezillon, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
https://bootlin.com