[PATCH] mtd: nand: tango: Fix incorrect use of SEQIN command

Boris Brezillon boris.brezillon at free-electrons.com
Mon May 15 15:30:01 PDT 2017


On Tue, 16 May 2017 00:10:24 +0200
Boris Brezillon <boris.brezillon at free-electrons.com> wrote:

> SEQIN is supposed to be used one wants to start programming a page.

			      ^ when one ...

> What we want here is just changing the column within the page, which is
> done with the RNDIN command.
> 

Forgot the following tags.

Fixes: 6956e2385a16 ("mtd: nand: add tango NAND flash controller support")
Cc: state at vger.kernel.org

> Signed-off-by: Boris Brezillon <boris.brezillon at free-electrons.com>
> ---
>  drivers/mtd/nand/tango_nand.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/tango_nand.c b/drivers/mtd/nand/tango_nand.c
> index 05b6e1065203..a2150b15d4c1 100644
> --- a/drivers/mtd/nand/tango_nand.c
> +++ b/drivers/mtd/nand/tango_nand.c
> @@ -332,7 +332,7 @@ static void aux_write(struct nand_chip *chip, const u8 **buf, int len, int *pos)
>  
>  	if (!*buf) {
>  		/* skip over "len" bytes */
> -		chip->cmdfunc(mtd, NAND_CMD_SEQIN, *pos, -1);
> +		chip->cmdfunc(mtd, NAND_CMD_RNDIN, *pos, -1);
>  	} else {
>  		tango_write_buf(mtd, *buf, len);
>  		*buf += len;




More information about the linux-mtd mailing list