[PATCH] driver: mtd: update struct map_info's swap as per map requirement.

Boris Brezillon boris.brezillon at free-electrons.com
Mon May 15 12:01:23 PDT 2017


On Mon, 15 May 2017 12:28:33 -0500
Scott Wood <oss at buserror.net> wrote:

> On Mon, 2017-05-15 at 10:48 +0200, Boris Brezillon wrote:
> > 
> > You can even make this property a string property:
> > 
> > 		if (!of_property_read_string(dp->parent,
> > 					     "cfi-endianness",
> > 					     &endianness)) {
> > 			if (!strcmp("big", endianness))
> > 				info->list[i].map.swap = CFI_BIG_ENDIAN;
> > 			else if (!strcmp("little", endianness))
> > 				info->list[i].map.swap = CFI_LITTLE_ENDIAN;
> > 			else if (!strcmp("host", endianness))
> > 				info->list[i].map.swap = CFI_HOST_ENDIAN;
> > 		}  
> 
> Boolean endianness properties are the standard elsewhere -- why should CFI be
> different?
> 
> See Documentation/devicetree/bindings/common-properties.txt

Forget this suggestion, I didn't know xxx-endian were standard props. My
first comment still applies though.



More information about the linux-mtd mailing list