[PATCH] spi-nor: use true/false for bool

Boris Brezillon boris.brezillon at free-electrons.com
Sun Feb 12 13:50:44 PST 2017


On Sun, 12 Feb 2017 17:43:31 +0100
Nicholas Mc Guire <der.herr at hofr.at> wrote:

> writeable in struct intel_spi is a boolean and assignment should be to 
> true/false not 1/0 as recommended by boolinit.cocci.
> 
> Signed-off-by: Nicholas Mc Guire <der.herr at hofr.at>

Acked-by: Boris Brezillon <boris.brezillon at free-electrons.com>

> ---
> 
> make coccicheck complained with:
>  ./drivers/mtd/spi-nor/intel-spi.c:707:3-18: WARNING: Assignment of bool to 0/1
> 
> Patch was compile tested with: multi_v7_defconfig (implies CONFIG_MTD_SPI_NOR=y)
> 
> Patch is against 4.10-rc6 (localversion-next is next-20170210)
> 
>  drivers/mtd/spi-nor/intel-spi.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/spi-nor/intel-spi.c b/drivers/mtd/spi-nor/intel-spi.c
> index a10f602..e43ce63 100644
> --- a/drivers/mtd/spi-nor/intel-spi.c
> +++ b/drivers/mtd/spi-nor/intel-spi.c
> @@ -704,7 +704,7 @@ static void intel_spi_fill_partition(struct intel_spi *ispi,
>  		 * whole partition read-only to be on the safe side.
>  		 */
>  		if (intel_spi_is_protected(ispi, base, limit))
> -			ispi->writeable = 0;
> +			ispi->writeable = false;
>  
>  		end = (limit << 12) + 4096;
>  		if (end > part->size)




More information about the linux-mtd mailing list