[PATCH v3] mtd: nand: tango: import driver for tango chips

[Boris Brezillon]

On Sun, 11 Sep 2016 14:50:19 +0200
Mason <slash.tmp at free.fr> wrote:

> On 09/09/2016 18:13, Marc Gonzalez wrote:
> 
> > This driver supports the NAND Flash controller embedded in recent
> > Tango chips, such as SMP8758 and SMP8759.
> > 
> > Signed-off-by: Marc Gonzalez <marc_gonzalez at sigmadesigns.com>
> > ---
> >  drivers/mtd/nand/Kconfig      |   6 +
> >  drivers/mtd/nand/Makefile     |   1 +
> >  drivers/mtd/nand/tango_nand.c | 482 ++++++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 489 insertions(+)
> >  create mode 100644 drivers/mtd/nand/tango_nand.c  
> 
> Still on the TODO/MAYBE list:
> 
> 1) Remove the cast in tango_write_page

Nice to have (especially since it's not required at all: do_dma() can
take a const void *)

> 2) Update stats.failed

Mandatory.

> 3) Implement read/write_oob

Mandatory. I've seen your questions on the #mtd chan regarding the
usefulness of ->read/write_oob(). I agree that most of the time it's
not needed, but some MTD users depends on it.

> 4) Report OOB layout to framework (?)

Mandatory. For the exact same reason.

> 5) Tweak (?) Peripheral Bus setup (timings and CS config)

That's up to you, but I'd recommend to sort this out before submitting
the next version.

> 6) Write device_cfg register (or report weirdness as a bug)

I don't get this one.