[RESEND PATCH v2 01/27] mtd-utils: Restructure the mtd-utils source.

Brian Norris computersforpeace at gmail.com
Tue Oct 27 16:00:07 PDT 2015


On Thu, Oct 15, 2015 at 12:10:08PM +0800, Dongsheng Yang wrote:
> * There is no code modification in this commit, only moving
> * the files to proper place.
> 
> The user tools looks a little messy as we place almost
> the all tools in the root directory of mtd-utils. To make
> it more clear, I propose to introduce the following structure
> for our source code.
> 
> mtd-utils/
> 	|-- lib
> 	|-- include
> 	|-- misc-utils
> 	|-- flash-utils

What's the difference between flash-utils and misc-utils? And don't just
tell me it's because they were named starting with "flash" :)

Particularly, I think things like "mtdpart" and "flash_erase" are pretty
similar levels of generic.

(Also, why is mtdinfo in ubi-utils still? It should be moved, IMO.)

> 	|-- jffsX-utils

What makes more sense: jffsX or just jffs?

> 	|-- nand-utils
> 	|-- nor-utils

What are specific to NOR flash? I don't even know what "rfddump" and
"rfdformat" are. Do they really deserve their own directory?

> 	|-- ubi-utils
> 	|-- ubifs-utils
> 	`-- tests

You need to update .gitignore too.

Brian



More information about the linux-mtd mailing list