[PATCH] UBI: Fastmap: Fix PEB array type

Richard Weinberger richard at nod.at
Sat Oct 17 11:04:06 PDT 2015


Am 17.10.2015 um 19:55 schrieb Ezequiel Garcia:
> The PEB array is an array of __be32, so let's fix the
> scan_pool() prototype accordingly.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel at vanguardiasur.com.ar>
> ---
>  drivers/mtd/ubi/fastmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/ubi/fastmap.c b/drivers/mtd/ubi/fastmap.c
> index db3defdfc3c0..c867707a1d04 100644
> --- a/drivers/mtd/ubi/fastmap.c
> +++ b/drivers/mtd/ubi/fastmap.c
> @@ -383,7 +383,7 @@ static void unmap_peb(struct ubi_attach_info *ai, int pnum)
>   * < 0 indicates an internal error.
>   */
>  static int scan_pool(struct ubi_device *ubi, struct ubi_attach_info *ai,
> -		     int *pebs, int pool_size, unsigned long long *max_sqnum,
> +		     __be32 *pebs, int pool_size, unsigned long long *max_sqnum,
>  		     struct list_head *eba_orphans, struct list_head *free)
>  {
>  	struct ubi_vid_hdr *vh;

The change makes sense, but does it fix a real issue?
I suspect it silences a compiler warning, which one?

Thanks,
//richard



More information about the linux-mtd mailing list