[PATCH] mtd: nand: Fix Spansion sparearea size detection

Nikolay Martynov mar.kolya at gmail.com
Mon Nov 30 20:20:03 EST 2015


Brian, thank you for detailed explanation!

Please disregard this patch then, since this problem is openwrt specific.
Thanks!

2015-11-30 20:05 GMT-05:00 Brian Norris <computersforpeace at gmail.com>:
> On Mon, Nov 30, 2015 at 07:19:22PM -0500, Nikolay Martynov wrote:
>> Hi.
>>
>>   I'm using mt7621 board, so this would be mtk_nand with matches from openwrt.
>
> Sorry, you'll have to address this to the OpenWrt team then. I see the
> OpenWrt NAND driver for your board is pretty crappy, but it might be
> fixable to support ONFI properly.
>
> Cc'ing John, who checked in mtk_nand.c into OpenWrt, I think.
>
> Regards,
> Brian
>
>> 2015-11-30 19:09 GMT-05:00 Brian Norris <computersforpeace at gmail.com>:
>> > Hi Nikolay,
>> >
>> > On Mon, Nov 30, 2015 at 06:59:32PM -0500, Nikolay Martynov wrote:
>> >>   I'm sorry, I only have board with S34ML02G2 and I've tested by
>> >> change on it - it works fine. But unfortunately I do not have any way
>> >> to test S34ML01G2.
>> >>   It looks like that logic can be simplified if just check id_data[1]
>> >> is one of 0xda, 0xdc, 0xca, 0xcc - this should be safer option.
>> >
>> > Possibly safer, but it's uglier, and I'd like not to have to make this
>> > change at all, if ONFI can help it.
>> >
>> >>   I'm sorry, I'm very new to all this. This patch made kernel boot on
>> >> a board that I have. The kernel was 'oldish' - 3.18. So I'm not sure
>> >> why ONFI is not used here, I will see if I can figure it out.
>> >
>> > What NAND driver are you using? It's possible that it doesn't support
>> > the PARAMETER READ command properly. If so, it'd be better to fix that
>> > than to clutter the NAND core.
>> >
>> > Regards,
>> > Brian
>>
>>
>>
>> --
>> Martynov Nikolay.
>> Email: mar.kolya at gmail.com



-- 
Martynov Nikolay.
Email: mar.kolya at gmail.com



More information about the linux-mtd mailing list