[PATCH] fix build when WITHOUT_LZO is set

Richard Weinberger richard.weinberger at gmail.com
Thu Nov 12 02:08:10 PST 2015


On Wed, Apr 8, 2015 at 11:32 AM, Richard Weinberger
<richard.weinberger at gmail.com> wrote:
> On Tue, Mar 10, 2015 at 3:52 PM, Rolf Eike Beer <eb at emlix.com> wrote:
>> From 3019806268ef1a9a483ca2bc35dcf1365415829f Mon Sep 17 00:00:00 2001
>> From: Rolf Eike Beer <eb at emlix.com>
>> Date: Tue, 10 Mar 2015 15:20:52 +0100
>> Subject: [PATCH] fix build when WITHOUT_LZO is set
>>
>> Make mkfs.ubifs honor the WITHOUT_LZO flag, too.
>>
>> Fixes this build error:
>>   mkfs.ubifs/compr.c:27:23: lzo/lzo1x.h: No such file or directory
>>   mkfs.ubifs/compr.c: In function `lzo_compress':
>>   mkfs.ubifs/compr.c:92: error: `lzo_uint' undeclared (first use in this function)
>>   mkfs.ubifs/compr.c:92: error: (Each undeclared identifier is reported only once
>>   mkfs.ubifs/compr.c:92: error: for each function it appears in.)
>>   mkfs.ubifs/compr.c:92: error: syntax error before "len"
>>   mkfs.ubifs/compr.c:95: error: `len' undeclared (first use in this function)
>>   mkfs.ubifs/compr.c:96: warning: implicit declaration of function `lzo1x_999_compress'
>>   mkfs.ubifs/compr.c:99: error: `LZO_E_OK' undeclared (first use in this function)
>>   mkfs.ubifs/compr.c: In function `init_compression':
>>   mkfs.ubifs/compr.c:201: error: `LZO1X_999_MEM_COMPRESS' undeclared (first use in this function)
> Patches makes sense to me.
>
> Maybe it would make sense to move LZO related stuff out of compr.c
> to reduce the amount of ifdefs.
>
> Artem, Brian, what do you think?

Sorry, this patch got lost. ;-\
I've applied and pushed it now as it fixes a real problem.

-- 
Thanks,
//richard



More information about the linux-mtd mailing list