[RFC PATCH RESEND] mtd-utils: Restructure the mtd-utils source.

Richard Weinberger richard at nod.at
Tue Jun 30 02:29:15 PDT 2015


Am 30.06.2015 um 09:41 schrieb Dongsheng Yang:
> On 06/30/2015 03:38 PM, Richard Weinberger wrote:
>> Am 30.06.2015 um 09:27 schrieb Dongsheng Yang:
>>> On 06/30/2015 03:19 PM, Richard Weinberger wrote:
>>>> Am 30.06.2015 um 08:50 schrieb Dongsheng Yang:
>>>>> * There is no code modification in this commit, only moving
>>>>> * the files to proper place.
>>>>>
>>>>> The user tools looks a little messy as we place almost
>>>>> the all tools in the root directory of mtd-utils. To make
>>>>> it more clear, I propose to introduce the following structure
>>>>> for our source code.
>>>>>
>>>>> mtd-utils/
>>>>>      |-- lib
>>>>>      |-- include
>>>>>      |-- misc-utils
>>>>>      |-- flash-utils
>>>>>      |-- jffsX-utils
>>>>>      |-- nand-utils
>>>>>      |-- nor-utils
>>>>>      |-- ubi-utils
>>>>>      |-- ubifs-utils
>>>>>      `-- tests
>>>>>
>>>>> Signed-off-by: Dongsheng Yang <yangds.fnst at cn.fujitsu.com>
>>>>
>>>> Hmm, while I agree with you that the current directory structure is not perfect
>>>> I'm not sure if it is worth the hassle. Because your patch hurts git blame.
>>>
>>> Good point. But seems the git currently is smart enough to show the
>>> right history in blame after a rename commit.
>>
>> Does it also after you've applied the patch file? i.e. git am your.patch.
>> IIRC git is able to deal with that only if you keep the patch in git.
> 
> I tried to reset --hard and apply it. That works too. And then I tried
> to apply this patch to another repo. I got the expected result in blame.

Oh, nice. :-)

>> BTW: Your patch does not apply to mtd-utils.git as of today.
> 
> Sorry about it. This patch does not apply to latest mtd-utils, I made it
> in a local repo. As my working network can not access:
> https://git.infradead.org/srv/git/mtd-utils.git/
> 
> You know, there are some strange limits about network in lots of china
> companies. :(
> 
> So, I marked it as RFC to see the opinions about this idea. I have to
> wait to go home this night to update my repo and rebase this patch.

I can feel your pain.

Thanks,
//richard



More information about the linux-mtd mailing list