[PATCH] jffs2:Fix error paths return value for the function read_unknown

Nicholas Krause xerofoify at gmail.com
Wed Jul 8 13:59:55 PDT 2015


This fixes the error paths in the function read_unknown that return
a value to correctly return -EIO rather then the kernel value for
successful function execution of zero to indicate to this function's
callers that a failure has occurred related to I/O and needs to be
handled by this function's caller.

Signed-off-by: Nicholas Krause <xerofoify at gmail.com>
---
 fs/jffs2/readinode.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/fs/jffs2/readinode.c b/fs/jffs2/readinode.c
index 28e0aab..63bf879 100644
--- a/fs/jffs2/readinode.c
+++ b/fs/jffs2/readinode.c
@@ -875,7 +875,7 @@ static inline int read_unknown(struct jffs2_sb_info *c, struct jffs2_raw_node_re
 			    je16_to_cpu(un->magic), je16_to_cpu(un->nodetype),
 			    je32_to_cpu(un->totlen), je32_to_cpu(un->hdr_crc));
 		jffs2_mark_node_obsolete(c, ref);
-		return 0;
+		return -EIO;
 	}
 
 	un->nodetype = cpu_to_je16(JFFS2_NODE_ACCURATE | je16_to_cpu(un->nodetype));
@@ -904,7 +904,7 @@ static inline int read_unknown(struct jffs2_sb_info *c, struct jffs2_raw_node_re
 		JFFS2_NOTICE("unknown RWCOMPAT_DELETE nodetype %#04X at %#08x\n",
 			     je16_to_cpu(un->nodetype), ref_offset(ref));
 		jffs2_mark_node_obsolete(c, ref);
-		return 0;
+		return -EIO;
 	}
 
 	return 0;
-- 
2.1.4




More information about the linux-mtd mailing list