[PATCH v3 2/2] mtd: fsl-quadspi: Fix module unbound

Fabio Estevam festevam at gmail.com
Tue Jan 13 13:45:22 PST 2015


Hi Brian,

On Tue, Jan 13, 2015 at 4:51 PM, Brian Norris
<computersforpeace at gmail.com> wrote:

>> - Read the two flashes.
>
> Are you doing any verification to make sure you're reading the *correct*
> data? I'd imagine from some what I see in your patches, that you might
> actually be reading from the wrong flash.

Yes, you are right. Just confirmed that with this v3 applied I erased
/dev/mtd0, but that also incorrectly erased /dev/mtd1.

Now I came back to the original v1 patch: isn't it the simpler
approach for fixing the module load/unload crash problem?

It only keeps the mtd unregistration index in sync with registration
and doesn't touch other areas of the driver.

IMHO it is an improvement over the current situation.

I agree that this driver needs more rework, but I am not able to put
it on such good state.

Please let me know your opinion.

Thanks,

Fabio Estevam



More information about the linux-mtd mailing list