[PATCH v2] mtd: nftl: reorganize operations in condition check

[Brian Norris]

On Sat, Jan 10, 2015 at 09:11:13PM +0100, Giel van Schijndel wrote:
> On Sat, Jan 10, 2015 at 14:56:32 +0200, Andy Shevchenko wrote:
> > On Sat, Jan 10, 2015 at 1:29 AM, Brian Norris <computersforpeace at gmail.com> wrote:
> >> On Wed, Jan 07, 2015 at 10:37:20PM +0200, Andy Shevchenko wrote:
> >>> We need to compare ret variable for negative value. The current code
> >>> assigns the boolean to the ret and prints it wrongly in the warning
> >>> message.
> >>>
> >>> Reported-by: Andrey Karpov <karpov at viva64.com>
> >>> Cc: Giel van Schijndel <me at mortis.eu>
> >>> Cc: Dimitri Gorokhovik <dimitri.gorokhovik at free.fr>
> >>> Signed-off-by: Andy Shevchenko <andy.shevchenko at gmail.com>
> >>
> >> To be clear, this touches some commented out code (yuck). I think you
> >> noted this previously.
> > 
> > It had been proposed by Giel.
> 
> Yes, and I suspect (and hope) Brian's referring to the existence of
> commented-out code as "yuck", not the removal of bugs from it.

Yes, I was just commenting about the existence of all that dead code.
The code won't even compile now, as it's using some old interfaces.

> >> For my reference, are you actually testing this driver?
> > 
> > Not a real testing. Only compilation on x86_32.
> 
> Combined with review I think that's enough given the nature of this
> change.

Yeah, I wasn't objecting to fixing this trivial stuff. I just don't know
who uses some of the aging drivers we have in MTD.

Brian