[PATCH mtd-utils] autogenerated dependency files are not being utilized properly

Brian Norris computersforpeace at gmail.com
Thu Aug 27 17:20:48 PDT 2015


On Thu, Aug 27, 2015 at 07:56:13PM -0400, Mike Frysinger wrote:
> On 27 Aug 2015 15:48, Brian Norris wrote:
> > -	$(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -Wp,-MD,$(BUILDDIR)/.$(<F).dep
> > +	$(Q)$(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@ $< -g -MD -MF $(BUILDDIR)/.$(<F).dep
> 
> fwiw, this has been here since the beginning.

Yeah, at first I thought it was added in your build system refactoring a
few years back, but then I traced it back to the beginning of time^Wgit
history. Anyway, I figured you'd have insight.

> dropping the -Wp makes
> sense to me.  independently, i think it should use -MMD, but others might
> prefer the -MD behavior.

-MMD makes sense to me too, but yes it is independent. I can send
another patch.

> Acked-by: Mike Frysinger <vapier at gentoo.org>

Thanks for the review!

Brian



More information about the linux-mtd mailing list