[PATCH v3] ubifs: make ubifs_[get|set]xattr atomic

Dongsheng Yang yangds.fnst at cn.fujitsu.com
Tue Aug 11 19:37:30 PDT 2015


On 08/11/2015 08:46 PM, Artem Bityutskiy wrote:
> On Tue, 2015-08-11 at 11:32 +0800, Dongsheng Yang wrote:
>> So, I think fields in host are all protected by host->ui_mutex and
>> fields in xattr inodes are all protected by individual ui_mutex.
>>
>> Am I missing something?
>
> OK, on a second look, your patch is probably fine.
>
>> BTW, I found I have to add ui_mutex in create_xattr() even if you
>> agree with it. :)
>
> I am not sure about this. I thought xattrs are not visible to anyone
> while they are being created, so you do not need any locking there,
> since you do not have anyone to race with you.

Makes sense.

Yang
>
> Artem/
>
>
>




More information about the linux-mtd mailing list