[PATCH] mtd: gpmi: Remove noisy error message

Richard Weinberger richard at nod.at
Tue Nov 11 12:22:46 PST 2014


Am 11.11.2014 um 21:16 schrieb Fabio Estevam:
> On Tue, Nov 11, 2014 at 6:10 PM, Richard Weinberger <richard at nod.at> wrote:
> 
>> If the development board has by default no NAND, disable the driver
>> in imx28-evk.dts file.
> 
> Again, people are free to put a NAND into the socket and just use it.

If people change their board they are free to fix their dts. :)

>> You can leave a comment how to enable the driver if an user creates
>> a new board based on this eval board with a NAND.
> 
> No, I don't think this is a good idea.
> 
> BTW, I don't see any other nand driver that prints error on the probe
> error path like this one.

mpc5121_nfc.c for example does. Before every "goto error" in mpc5121_nfc_probe()
it prints an error message.

Thanks,
//richard



More information about the linux-mtd mailing list