[PATCH 06/35] UBI: Fastmap: Ensure that all fastmap work is done upon WL shutdown

Artem Bityutskiy dedekind1 at gmail.com
Wed Nov 5 07:45:07 PST 2014


On Wed, 2014-10-29 at 13:45 +0100, Richard Weinberger wrote:
> ...otherwise the deferred work might run after datastructures
> got freed and corrupt memory.
> 
> Signed-off-by: Richard Weinberger <richard at nod.at>
> ---
>  drivers/mtd/ubi/wl.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mtd/ubi/wl.c b/drivers/mtd/ubi/wl.c
> index bd2e8d5..a06e31e 100644
> --- a/drivers/mtd/ubi/wl.c
> +++ b/drivers/mtd/ubi/wl.c
> @@ -2047,6 +2047,9 @@ static void protection_queue_destroy(struct ubi_device *ubi)
>  void ubi_wl_close(struct ubi_device *ubi)
>  {
>  	dbg_wl("close the WL sub-system");
> +#ifdef CONFIG_MTD_UBI_FASTMAP
> +	flush_work(&ubi->fm_work);
> +#endif

I see in patch 35 you introduced the init function. Could you please
introduce fastmap init/close functions earlier, and add this line to the
fastmap close function instead of adding yet another ifdef to wl.c.




More information about the linux-mtd mailing list