[PATCH] ubifs: add missing ui pointer in debugging code

Artem Bityutskiy dedekind1 at gmail.com
Wed May 28 01:04:50 PDT 2014

On Wed, 2014-05-28 at 10:27 +0800, hujianyang wrote:
> Hi Artem,
> I think you made a small mistake:

Indeed, and not that small, even. I'll fix this, thanks!

If I was writing this code now, I would not bother using shifts, I'd
just use divisions, which are simpler and less error-prone. And modern
compilers are smart enough to optimize the code to use shifts when the
divider is a constant.

Best Regards,
Artem Bityutskiy

More information about the linux-mtd mailing list