[PATCH 09/10] mtd: st_spi_fsm: Provide mask to obtain correct boot device pins
arnd at arndb.de
Thu May 22 04:53:52 PDT 2014
On Thursday 22 May 2014 12:52:16 Lee Jones wrote:
> > On Thursday 22 May 2014 12:24:07 Lee Jones wrote:
> > > + /* Mask to apply on boot_device_reg */
> > > + ret = of_property_read_u32(np, "st,boot-device-msk", &boot_device_msk);
> > > + if (ret)
> > > + goto boot_device_fail;
> > > +
> > >
> > The binding defines this property as "optional", but the driver fails
> > here if it's not provided. I suggest you add a default value here so you
> > can deal with existing dts. The default should be documented in
> > the binding as well.
> The property is optional. It doesn't fail completely, merely skips the
> boot device check and falls back to using SPI. I can update the
> documentation to this effect though, no problem.
Ah, I see, thanks for the explanation!
More information about the linux-mtd