[PATCH v3] mtd: lpddr: add driver for LPDDR2-NVM PCM memories

Brian Norris computersforpeace at gmail.com
Wed May 14 09:19:17 PDT 2014


Hi,

On Wed, May 14, 2014 at 09:44:38AM +0200, Vincenzo Aliberti wrote:
> Hi Brian,
>    your feedback looks great! Thanks!
> 
> Only one concern: I have been forced to test it on a 3.10_rc4 version
> of the Kernel and in order to use
> IS_ERR and PTR_ERR functions I had to add:
> 
> #include <linux/err.h>
> 
> On the 3.14 I expect it should be the same, which is your feeling?

Yeah, I missed the #include. It must have been included implicitly by
another header. But it should be included explicitly.

> Do you wnat I send a v4 of this patch?

Please do.

Brian



More information about the linux-mtd mailing list