[RFC PATCH] UBI: fix rb_tree node comparison in add_map

Artem Bityutskiy dedekind1 at gmail.com
Tue May 13 02:08:09 PDT 2014


On Fri, 2014-05-09 at 18:19 -0700, Brian Norris wrote:
> Hi Artem,
> 
> On Sat, Mar 22, 2014 at 12:56:59AM +0100, Richard Weinberger wrote:
> > Am 21.03.2014 20:54, schrieb Mike Snitzer:
> > > The comparisons used in add_vol() shouldn't be identical.  Pretty sure
> > > the following is correct but it is completely untested.
> > > 
> > > Signed-off-by: Mike Snitzer <snitzer at redhat.com>
> > > ---
> > >  drivers/mtd/ubi/fastmap.c |    4 ++--
> > >  1 files changed, 2 insertions(+), 2 deletions(-)
> > > 
> > > NOTE: I stumbled upon this code while implementing some rb_tree code
> > >       (and looking for some existing rb_tree code as a reference).
> > 
> > Thanks a lot for pointing this out!
> > 
> > Acked-by: Richard Weinberger <richard at nod.at>
> 
> Bump?
> 
> I'm passing through my queue, and I occasionally see some obvious,
> reviewed fixes like this one. Typically, you get around to them
> eventually, but you never know. Do you prefer the "bump"?

I'll pick this now, thanks for pointing. And yes, a "bump" is helpful.
E.g., I missed this ones.

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list