[PATCH v2] mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page

Brian Norris computersforpeace at gmail.com
Mon May 12 13:36:26 PDT 2014

On Tue, Mar 25, 2014 at 12:28:19PM +0530, Pekon Gupta wrote:
> fixes: commit 62116e5171e00f85a8d53f76e45b84423c89ff34
>        mtd: nand: omap2: Support for hardware BCH error correction.
> In omap_elm_correct_data(), if bitflip_count in an erased-page is within the
> correctable limit (< ecc.strength), then it is not indicated back to the caller
> ecc->read_page().
> This mis-guides upper layers like MTD and UBIFS layer to assume erased-page as
> perfectly clean and use it for writing even if actual bitflip_count was
> dangerously high (bitflip_count > mtd->bitflip_threshold).
> This patch fixes this above issue, by returning 'stats' to caller
> ecc->read_page() under all scenarios.
> Reported-by: Brian Norris <computersforpeace at gmail.com>
> Signed-off-by: Pekon Gupta <pekon at ti.com>

Pushed to l2-mtd.git. Thanks!


More information about the linux-mtd mailing list