[PATCH V2] mtd:nor:timeout:fix do_write_buffer() timeout error

Bean Huo 霍斌斌 (beanhuo) beanhuo at micron.com
Mon Jun 23 17:50:08 PDT 2014


Hi,
>I tried to test this version of your patch, but cannot apply it. On which kernel version does it apply?
This patch checkout from mainline 3.15.0-rc8,and git address as below:
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git

>>         unsigned long timeo = jiffies + HZ;
>> -       /* see comments in do_write_oneword() regarding uWriteTimeo. */
>> -       unsigned long uWriteTimeout = ( HZ / 1000 ) + 1;
>> +       /* The size of the buffer program has been increased from 256 to 512,
>> +        * 2ms maximum timeout can not adapt to all the different vendor's
>> +        * norflash.There maximum timeout information in the CFI area,so the
>> +        * best way is to choose the result calculated according to timeout
>> +        * field of struct cfi_ident that probed from norflash's CFI aera,see
>> +        * comments in cfi_cmdset_0002().uWriteTimeout is used for timeout step,
>> +        * it must be concerted into jiffies.

>I think the reference to the old 2ms timeout only confuses readers, since they don't know the old code. Putting this into the commit message is sufficient. 

I think you could delete this comment here.
OK,thanks for your suggest,I will put this message into commit message. 

>> +        */
>> +       unsigned long uWriteTimeout =

>Trailing whitespace, please remove that. Please run your patch through scripts/checkpatch.pl to detect such errors.

I have checked it by checkpatch.pl,but no error and warning.i will double check it in the next version.i hope this patch can be accepted as soon as possible.
I want to commit other timeout error patches.thanks!




More information about the linux-mtd mailing list