[RFC "v2"] mtd: nand: reintroduce NAND_NO_READRDY as NAND_NEED_READRDY

David Woodhouse dwmw2 at infradead.org
Thu Mar 14 06:51:37 EDT 2013


On Thu, 2013-03-14 at 12:41 +0200, Artem Bityutskiy wrote:
> On Wed, 2013-03-13 at 09:51 -0700, Brian Norris wrote:
> > +			if (chip->options & NAND_NEED_READRDY) {
> > +				/* Apply delay or wait for ready/busy pin */
> > +				if (!chip->dev_ready)
> > +					udelay(chip->chip_delay);
> > +				else
> > +					nand_wait_ready(mtd);
> > +			}
> 
> Am I right that this is a small page NAND-specific thing? If yes, can we
> just this magic to all small page NANDs without introducing the option?

Probably, but the option flag is the cleaner way of doing it. Yes, it's
a slightly more intrusive patch right now, but it's nicer.

> Also, irrespectively of the final solution, let's do it this way:
> 
> 1. Create a patch against the 3.9-rc2, not l2-mtd.git, and test it.
> 2. Add Cc stable, just like David asked.
> 2. Bug David to merge it.
> 3. I rebase the l2 tree on top of that.

I've got a couple of (unrelated) patches in linux-mtd.git which I was
about to send to Linus for 3.9. Let's put it on top of that and I'll
send the whole lot together.

-- 
dwmw2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: smime.p7s
Type: application/x-pkcs7-signature
Size: 6171 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20130314/a50714f9/attachment-0001.bin>


More information about the linux-mtd mailing list