[PATCH] mtd: devices: elm: check for device's presence before configuration

Daniel Mack zonque at gmail.com
Sun Mar 3 16:12:58 EST 2013


In case the driver is not probed - due to config mismatches or errors
in the DTS files - dev_get_drvdata() returns NULL, leading to an Ooops
during boot. Better bail out with a warning in such cases.

Signed-off-by: Daniel Mack <zonque at gmail.com>
Cc: Philip Avinash <avinashphilip at ti.com>
Cc: Artem Bityutskiy <artem.bityutskiy at linux.intel.com>
---
 drivers/mtd/devices/elm.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
index 2ec5da9..a9b6d04 100644
--- a/drivers/mtd/devices/elm.c
+++ b/drivers/mtd/devices/elm.c
@@ -86,6 +86,11 @@ void elm_config(struct device *dev, enum bch_ecc bch_type)
 	u32 reg_val;
 	struct elm_info *info = dev_get_drvdata(dev);
 
+	if (!info) {
+		dev_err(dev, "Unable to configure elm - device not probed?\n");
+		return;
+	}
+
 	reg_val = (bch_type & ECC_BCH_LEVEL_MASK) | (ELM_ECC_SIZE << 16);
 	elm_write_reg(info, ELM_LOCATION_CONFIG, reg_val);
 	info->bch_type = bch_type;
-- 
1.8.1.4




More information about the linux-mtd mailing list