[PATCH] mtd: mxc_nand: add missing clk_disable_unprepare() in mxcnd_remove()

Brian Norris computersforpeace at gmail.com
Tue Dec 17 02:26:46 EST 2013


+ Sascha

On Tue, Dec 17, 2013 at 11:35:35AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei at trendmicro.com.cn>
> 
> clock source is prepared and enabled by clk_prepare_enable() in
> mxcnd_probe() function, but no disable/unprepare in mxcnd_remove().
> 
> Signed-off-by: Wei Yongjun <yongjun_wei at trendmicro.com.cn>

Looks good, thanks. Applied to l2-mtd.git.

> ---
>  drivers/mtd/nand/mxc_nand.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mtd/nand/mxc_nand.c b/drivers/mtd/nand/mxc_nand.c
> index 7a4e032..567a5e5 100644
> --- a/drivers/mtd/nand/mxc_nand.c
> +++ b/drivers/mtd/nand/mxc_nand.c
> @@ -1577,6 +1577,8 @@ static int mxcnd_remove(struct platform_device *pdev)
>  	struct mxc_nand_host *host = platform_get_drvdata(pdev);
>  
>  	nand_release(&host->mtd);
> +	if (host->clk_act)
> +		clk_disable_unprepare(host->clk);
>  
>  	return 0;
>  }
> 

Brian



More information about the linux-mtd mailing list