[PATCH] mtd: m25p80: add support for Spansion s25fl128s chip

[Brian Norris]

(Leaving Huang's email intact, since it was in HTML format and didn't
make it through the list's filter; Huang, you really need to fix this.)

On Fri, Nov 22, 2013 at 10:13:02AM +0800, Huang Shijie wrote:
> 于 2013年11月21日 19:08, Angus Clark 写道:
> 
>     Assuming you a referring to the same M25P80_QUAD_READ flag as introduced by
>     "[PATCH] drivers: mtd: m25p80: Add quad read support.", then the flag invokes
>     OPCODE_QUAD_READ = 0x6b, which corresponds to the Spansion *SDR* "QOR" command.
>      The DDR QUAD Read command is 0xed, "DDRQIOR" (there is no DDR equivalent of
>     "QOR").  So, again, I believe the m25p80 driver is not sensitive to the
>     differences between s25fl129p1 and s25fl128s1; the M25P80_QUAD_READ flag, as is
>     stands, applies equally to both.
> 
> The current m25p80 is not sensitive, but i am changing the this driver now.
> In the future, it should support the DDR QUAD READ. this patch is just making
> preparation for
> the DDR QUAD read.
> 
> And I will submit a patch to read out the 6th READID to distinguish the two
> different NOR.

So to be clear, this patch can't go in as-is.

BTW, if we update m25p80 to use 6th-byte READID, we need to double-check
the entries that currently use the 5-byte ID string, so they don't break
if we extend them implicitly.

Brian