[PATCH 08/11] mtd: add a new field for ecc info in the nand_flash_dev{}

Artem Bityutskiy dedekind1 at gmail.com
Tue Apr 16 10:56:35 EDT 2013


On Mon, 2013-03-18 at 19:18 +0800, Huang Shijie wrote:
> +#define ECC_INFO(strength, size)	(((strength) << 16) | (size))
> +#define ECC_STRENGTH(x)			(((x) >> 16) & 0xffff)
> +#define ECC_SIZE(x)			((x) & 0xffff)
> +	uint32_t ecc_info;
>  };

Could you please avoid putting macro definition in the middle of the
structure. Put it before the structure.

Also, probably prefixing with NAND_ would make sense?

-- 
Best Regards,
Artem Bityutskiy




More information about the linux-mtd mailing list