[PATCH 1/4] mtd: prepare place for BCMA NAND flash driver(s)

Artem Bityutskiy dedekind1 at gmail.com
Wed Sep 26 03:43:30 EDT 2012


On Wed, 2012-09-26 at 09:41 +0200, Rafał Miłecki wrote:
> 2012/9/26 Artem Bityutskiy <dedekind1 at gmail.com>:
> > On Wed, 2012-09-12 at 22:21 +0200, Rafał Miłecki wrote:
> >> +config MTD_NAND_BCM47XXNFLASH
> >> +     tristate "Support for NAND flash on BCMA bus"
> >> +     depends on BCMA_NFLASH && BROKEN
> >> +     help
> >> +       BCMA bus can have various flash memories attached, they are
> >> +       registered by bcma as platform devices. This enables driver for
> >> +       NAND flash memories.
> >
> > Could we please merge only non-broken stuff upstream. I understand your
> > intentions to merge something non-working first with a promise to make
> > it working later, but I do not think this is an acceptable approach.
> >
> > Why exactly you mark this one as broken? If it is R/O so far, and
> > reading works, and you tested it (how?), we can merge it I guess, just
> > make it clear that it is R/O in Kconfig help text.
> 
> Yes, BROKEN can be dropped from this. I'll resend correct patchset
> after checking it with verify/aiaiai (i'm almost done! :) )

Great, thanks. Do not forget to tell about R/O in the Kconfig text
please!

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-mtd/attachments/20120926/f3554dcf/attachment.sig>


More information about the linux-mtd mailing list