[PATCH] NAND BBT: use NAND_BBT_SCAN_MAXBLOCKS

Brian Norris computersforpeace at gmail.com
Fri Sep 14 23:11:41 EDT 2012


Hi,

On Tue, Sep 11, 2012 at 6:50 AM, Richard Genoud
<richard.genoud at gmail.com> wrote:
> In nand_bbt.c, a hardcoded value was used instead of the define meant
> for that, so we use the define.
>
> There's no functionnal change.

s/functionnal/functional

> Signed-off-by: Richard Genoud <richard.genoud at gmail.com>

> -       .maxblocks = 4,
> +       .maxblocks = NAND_BBT_SCAN_MAXBLOCKS,

On a more important note: why was this define ever included in the
first place? It seems to have been included without a real user in
this commit:

Author: Kyungmin Park <kyungmin.park at samsung.com>
Date:   Tue Sep 27 11:26:39 2005 +0100

    [MTD] OneNAND: Add missing files

In the end, the real question is: does the macro have real value? I
suppose it makes it slightly easier to change the parameter across all
the version of the BBT (main/mirror and oob/no_oob). So I'll ack:

Acked-by: Brian Norris <computersforpeace at gmail.com>

Thanks,
Brian



More information about the linux-mtd mailing list